Nexory commented on PR #1880: URL: https://github.com/apache/wicket/pull/1880#issuecomment-6814143758
Thanks for the review, the follow-up commit addresses each point. The client is opt-in: the server renders `<meta name="wicket-trusted-types">` only when a CSP header allows the `wicket` policy, and without it both engines behave as on master. With the option the jQuery engine parses markup with a `template` element and inserts it with the DOM API, so scripts in markup run as with `wicket-ajax.js`. `MultiSelector` keeps its two functions, and `migration-to-12.md` describes the change to its list. `TRUSTED_TYPES` accepts `CSPDirectiveSrcValue.NONE`, `requireTrustedTypes()` is idempotent, and the guide keeps only the `onselect` limitation. It still names jQuery 4 as a requirement, because jQuery 3 does not load under enforcement. No Wicket module passes string handlers to `Wicket.Ajax`. The examples enable the option; for them `Form` passes the hidden fields of its submit scripts through the policy. The tests you listed are added. One question: the `prototype` example breaks, because the bundled `prototype.js` assigns a string to `innerHTML`. Should that application drop the two directives, or stop using `Ajax.Updater`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
