reiern70 opened a new pull request, #1889: URL: https://github.com/apache/wicket/pull/1889
Backport of #1887 to `wicket-10.x`, for GitHub issue #1884. - 3496aee26f, cherry-picked from #1887: `EmailAddressValidator` escapes the hyphens in its pattern. On 10.x, `AbstractTextComponent` does not render the `pattern` attribute itself, but the `HTML5Attributes` behavior does. So the bug shows only on an `EmailTextField` with `HTML5Attributes`, and the class javadoc of `PatternValidator` names that behavior instead. The commit message is adapted to match. With `HTML5Attributes`, the browser now compiles the pattern and enforces it. Without it, nothing changes. No API change: japicmp reports nothing for the validator classes against 10.0.0, and applications have nothing to migrate. Verified on this branch: - `EmailValidatorTest` passes. - `mvn clean verify -Pjs-test` is green, japicmp included. This goes in after #1887. If #1887 changes in review, this branch gets the same change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
