dashorst opened a new pull request, #1896: URL: https://github.com/apache/wicket/pull/1896
The reference guide's fonts are out of the source tree: the `guide` profile now unpacks them from the fontsource webjars at build time, so a source release made with `git archive` no longer contains them. Alegreya, Alegreya Sans, Alegreya SC and JetBrains Mono are under the SIL OFL 1.1, which the ASF puts in [Category B](https://www.apache.org/legal/resolved.html#category-b): allowed in a built artifact, not in a source release. Part of #1846; the fonts of wicket-examples are still in the tree and are not touched here. - A `maven-dependency-plugin:unpack` execution in `generate-sources` takes the eight woff2 files that `css/wicket.css` uses from `org.webjars.npm:fontsource__{alegreya,alegreya-sans,alegreya-sc,jetbrains-mono}:5.3.0` and puts them flat in `target/generated-docs/fonts/`, each family with its licence as `LICENSE-<family>.txt`. The CSS and the preloads in `docinfo.html` keep their paths. - The unpacked files are byte for byte the ones removed (sha1 compared), so the guide looks the same. - `src/main/asciidoc/fonts/`, its line in `.rat-excludes` and its entry in `LICENSE` go. - The font stacks fall back to old-style serifs and humanist sans faces that the systems ship, the same stacks as the site (apache/wicket-site#27). ## For review - **Core:** the `unpack-fonts` execution in `wicket-user-guide/pom.xml`. The file mappers are repeated in every artifact item because `unpack` ignores an execution-level `fileMappers` when `artifactItems` are given. - **Mechanical:** the deleted font files and licence texts, `.rat-excludes`, `LICENSE`, and the four stack tokens in `css/wicket.css`. - **Build:** building the guide now downloads four small jars from Maven Central. The version is the `fontsource.version` property. ## Tested - `mvn -pl wicket-user-guide -Pguide clean generate-resources`: `target/generated-docs/fonts/` holds the 8 woff2 files and 4 licences, and every font URL in `css/wicket.css` and every preload in `single.html` resolves. - `mvn -pl wicket-user-guide verify` without the profile, and `mvn -N apache-rat:check`: green. - `git archive` of the tree: no font files under `wicket-user-guide`. The 66 of wicket-examples remain. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
