This is an automated email from the ASF dual-hosted git repository.

dashorst pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to refs/heads/master by this push:
     new 89e4f1fb88 Render three tests' pages in the locale their expected 
files assume
89e4f1fb88 is described below

commit 89e4f1fb888c6b203545eb5f4d4ac5320a8b9f16
Author: Martijn Dashorst <[email protected]>
AuthorDate: Sun Nov 15 10:29:50 2026 +0100

    Render three tests' pages in the locale their expected files assume
    
    Since #1870 a page writes lang and dir on its <html> tag from the page
    locale, and the expected-output files were updated to lang="en-US".
    WicketTestCase.newWicketTester pins the request locale to Locale.US for
    that reason, but three tests build their own WicketTester and render in
    the JVM default locale:
    
    - EnclosureTest.testRenderPage13
    - XForwardedRequestWrapperTest.test7
    - CSPTrustedTypesTest.renderWithoutCsp, which #1880 added while #1870 was
      open; it compares a page rendered by the test's tester with one from a
      second tester, so the two disagreed on lang
    
    On a JVM whose locale is not en_US, such as the CI runners (lang="en")
    or nl_NL, these three failed, which broke master's build after #1870 was
    merged. They now use newWicketTester. wicket-core-tests and
    wicket-extensions pass with the JVM locale set to en and to nl_NL.
    
    Generated-by: Claude Code (Claude Opus 5.5)
---
 .../src/test/java/org/apache/wicket/csp/CSPTrustedTypesTest.java        | 2 +-
 .../test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java | 2 +-
 .../wicket/protocol/http/servlet/XForwardedRequestWrapperTest.java      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/wicket-core-tests/src/test/java/org/apache/wicket/csp/CSPTrustedTypesTest.java
 
b/wicket-core-tests/src/test/java/org/apache/wicket/csp/CSPTrustedTypesTest.java
index 2b884d6088..d144a007dc 100644
--- 
a/wicket-core-tests/src/test/java/org/apache/wicket/csp/CSPTrustedTypesTest.java
+++ 
b/wicket-core-tests/src/test/java/org/apache/wicket/csp/CSPTrustedTypesTest.java
@@ -114,7 +114,7 @@ class CSPTrustedTypesTest extends WicketTestCase
 
        private String renderWithoutCsp()
        {
-               WicketTester withoutCsp = new WicketTester(new 
MockApplication());
+               WicketTester withoutCsp = newWicketTester(new 
MockApplication());
                try
                {
                        withoutCsp.startPage(AjaxPage.class);
diff --git 
a/wicket-core-tests/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
 
b/wicket-core-tests/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
index 878c500f55..6f16e76e8d 100644
--- 
a/wicket-core-tests/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
+++ 
b/wicket-core-tests/src/test/java/org/apache/wicket/markup/html/internal/EnclosureTest.java
@@ -350,7 +350,7 @@ class EnclosureTest extends WicketTestCase
        @Test
        void testRenderPage13() throws Exception
        {
-               tester = new WicketTester(new MockApplication()
+               tester = newWicketTester(new MockApplication()
                {
                        @Override
                        protected void init()
diff --git 
a/wicket-core-tests/src/test/java/org/apache/wicket/protocol/http/servlet/XForwardedRequestWrapperTest.java
 
b/wicket-core-tests/src/test/java/org/apache/wicket/protocol/http/servlet/XForwardedRequestWrapperTest.java
index 5aeba25eda..1d5ad3ff6a 100644
--- 
a/wicket-core-tests/src/test/java/org/apache/wicket/protocol/http/servlet/XForwardedRequestWrapperTest.java
+++ 
b/wicket-core-tests/src/test/java/org/apache/wicket/protocol/http/servlet/XForwardedRequestWrapperTest.java
@@ -195,7 +195,7 @@ class XForwardedRequestWrapperTest extends WicketTestCase
        void test7() throws Exception
        {
                MyApplication app = new MyApplication();
-               tester = new WicketTester(app);
+               tester = newWicketTester(app);
 
                
app.factory.getConfig().setAllowedInternalProxies("192\\.168\\.0\\.10, 
192\\.168\\.0\\.11");
                app.factory.getConfig().setRemoteIPHeader("x-forwarded-for");

Reply via email to