dashorst opened a new pull request, #1937:
URL: https://github.com/apache/wicket/pull/1937
## Summary
- Brings the restyled reference guide from master to wicket-11.x as two
cherry-picks: `745ae018ec` (style) and `e5999f0896` (fonts). Both keep the `-x`
line, and neither needed an 11.x-specific change.
- Restyles the guide to match wicket.apache.org: header, stylesheet, script,
SVG mark, docinfo, Rouge highlighting with a language label and copy button,
and dark mode.
- Takes the fonts (Alegreya, Alegreya Sans, Alegreya SC, JetBrains Mono)
from fontsource webjars at build time, so no font files enter the source tree.
The fonts are SIL OFL, which the ASF classes as Category B. The fonts commit
has to ship with the style commit, otherwise the font files would land in the
source tree alone.
- Removes the Asciidoctor default stylesheet, its LICENSE entry, its
`.rat-excludes` line and `licenses/LICENSE-asciidoctor.txt`.
- The title, masthead and Javadoc link now come from the project version, so
the 11.x guide reads "Wicket 11.x" and links to the 11.x apidocs.
- The conflict was only the title line of `single.adoc`, resolved to
master's `= Wicket {wicket_line} Reference Guide`.
- Not included: the follow-ups #1903, #1904 and #1929, which are not on
master yet. #1840 is not touched.
## Testing
- `mvn -pl wicket-user-guide -Pguide generate-resources` builds
`single.html` and `single.pdf`.
- Full `mvn clean verify -Pjs-test` on the branch: BUILD SUCCESS.
- `mvn -N apache-rat:check`: passes.
- `git ls-tree -r --name-only HEAD wicket-user-guide | grep -iE
'\.(woff2?|ttf|otf)$'` returns nothing.
- Rendered `single.html`: the title and masthead say 11.x, and the Javadoc
link points to https://nightlies.apache.org/wicket/apidocs/11.x/index.html.
- Listings: 522 of 527 are highlighted, and each has a language label and a
copy button. The other 5 are not highlighted; the cause was not checked.
- In a browser served over HTTP, the page makes no requests outside its own
origin, and the fonts load locally.
- Light mode, dark mode and a 390 px phone width were checked in a browser,
and dark mode works.
- Known gap, also on master and not changed here: at 1280 px the page
scrolls 304 px sideways, because `#footer` keeps the full viewport width while
getting `margin-left: var(--toc-w)`. At 390 px the page is 408 px wide, which
is the overflow #1903 addresses.
GitHub issue #1932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]