dashorst opened a new pull request, #1934:
URL: https://github.com/apache/wicket/pull/1934

   The OFL fonts of wicket-examples are out of the source tree, so a source 
release made with `git archive` contains no font software any more. Together 
with #1896 this leaves no font files in the repository. Source Sans Pro, Source 
Code Pro and League Gothic are under the SIL OFL 1.1, which the ASF puts in 
[Category B](https://www.apache.org/legal/resolved.html#category-b): allowed in 
a built artifact, not in a source release. Part of #1846.
   
   Two commits:
   
   - **Outline the examples logo and drop League Gothic.** 
`logo-apachewicket-examples-white.svg`, the only logo in use 
(`WicketExampleHeader`, `HomePageHeader`), had League Gothic base64-embedded. 
Its two `<text>` elements are now paths, drawn from that same font with its 
kerning at the same size and position, and each keeps its word as `aria-label`. 
The three other logo SVGs with the embedded font (`apachewicket7.svg`, 
`logo-apachewicket-tungsten.svg`, `logo-apachewicket-white.svg`) were 
referenced by nothing and are deleted, as is `fonts/league-gothic/`.
   - **Take the examples' text and code fonts from webjars at build time.** A 
`maven-dependency-plugin:unpack` execution in `generate-resources`, the same 
approach as #1896, puts the woff2 files the stylesheets use into 
`target/classes/org/apache/wicket/examples/fonts/`, each family with its 
licence as `LICENSE-<family>.txt`. The new `fonts.css` (Apache licence) 
declares them with `@font-face` and replaces the old kits' stylesheets. The 
fonts directory, its `.rat-excludes` line and the SIL OFL section of `LICENSE` 
go.
   
   ## Visible changes
   
   - **Code font:** Source Code Pro becomes **JetBrains Mono** 
(`fontsource__jetbrains-mono:5.3.0`), because no Source Code Pro webjar exists 
on Maven Central. It is the code font of the guide and the site. Code looks 
wider, with a taller x-height.
   - **Text font:** still **Source Sans Pro**, but version 2.045 
(`fontsource__source-sans-pro:5.2.5`) instead of the 1.033 Font Squirrel kit 
from 2012. Text sits about 2px lower per block and sets slightly tighter, so 
the odd line wraps differently.
   - **Logo:** unchanged. At 3× in Chromium, 180 of 374,400 pixels differ, all 
on glyph edges where text and a filled path anti-alias differently.
   - **Fallback:** without the fonts (an IDE run, or a build that hasn't 
unpacked them), text falls back to Segoe UI, Myriad Pro, Ubuntu, Noto Sans, 
Helvetica Neue or Arial, and code to the guide's monospace stack.
   
   ## For review
   
   - **Core:** the `unpack-fonts` execution in `wicket-examples/pom.xml`, 
`fonts.css` and the four font stacks in `style.css`.
   - **Mechanical:** the deleted fonts and SVGs, `.rat-excludes`, `LICENSE`, 
and the removed woff/ttf resource includes.
   - **Licensing:** the examples war is not in the binary distribution, which 
copies only jars, so `LICENSE-binary` is unchanged. The war carries each font's 
licence next to the files, and the OFL needs no NOTICE entry.
   
   ## Tested
   
   - `git ls-tree -r --name-only HEAD | grep -iE '\.(woff2?|ttf|otf|eot)$'` 
returns nothing.
   - `mvn -N apache-rat:check` and `mvn clean verify -Pjs-test` are green.
   - The examples ran with `jetty:run` and the pages were checked in headless 
Chromium: home, forminput, bean-validation and navomatic, before and after. The 
loaded faces are Source Sans Pro 300/400/700 and JetBrains Mono 300, and the 
woff2 files are served as `font/woff2`. With the woff2 requests blocked, the 
pages fall back cleanly.
   
   Backports: wicket-11.x and wicket-10.x get their own PRs.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to