svn commit: r1070013 - in /webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi: AbstractPolicyOperator.java AssertionBuilderFactory.java builders/xml/XmlPrimitiveAssertion.java

[dkulp]

Author: dkulp
Date: Sat Feb 12 02:31:30 2011
New Revision: 1070013

URL: http://svn.apache.org/viewvc?rev=1070013&view=rev
Log:
Minor PMD flagged changes

Modified:
    
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AbstractPolicyOperator.java
    
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AssertionBuilderFactory.java
    
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/xml/XmlPrimitiveAssertion.java

Modified: 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AbstractPolicyOperator.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AbstractPolicyOperator.java?rev=1070013&r1=1070012&r2=1070013&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AbstractPolicyOperator.java
 (original)
+++ 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AbstractPolicyOperator.java
 Sat Feb 12 02:31:30 2011
@@ -170,7 +170,7 @@ public abstract class AbstractPolicyOper
                 if (!exactlyOne.isEmpty()) {
                     ExactlyOne currentExactlyOne;
 
-                    for (; iter.hasNext();) {
+                    while (iter.hasNext()) {
                         currentExactlyOne = (ExactlyOne) iter.next();
                         if (currentExactlyOne.isEmpty()) {
                             // if this is empty, this is an not admissible 
policy and total 

Modified: 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AssertionBuilderFactory.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AssertionBuilderFactory.java?rev=1070013&r1=1070012&r2=1070013&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AssertionBuilderFactory.java
 (original)
+++ 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/AssertionBuilderFactory.java
 Sat Feb 12 02:31:30 2011
@@ -59,7 +59,7 @@ public class AssertionBuilderFactory {
         for (AssertionBuilder builder : 
Service.providers(AssertionBuilder.class)) {
             QName[] knownElements = builder.getKnownElements();
             for (int i = 0; i < knownElements.length; i++) {
-                registerBuilder(knownElements[i], builder);
+                registeredBuilders.put(knownElements[i], builder);
             }
         }
         defaultBuilder = new XMLPrimitiveAssertionBuilder();

Modified: 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/xml/XmlPrimitiveAssertion.java
URL: 
http://svn.apache.org/viewvc/webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/xml/XmlPrimitiveAssertion.java?rev=1070013&r1=1070012&r2=1070013&view=diff
==============================================================================
--- 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/xml/XmlPrimitiveAssertion.java
 (original)
+++ 
webservices/commons/trunk/modules/neethi/src/main/java/org/apache/neethi/builders/xml/XmlPrimitiveAssertion.java
 Sat Feb 12 02:31:30 2011
@@ -63,7 +63,7 @@ public class XmlPrimitiveAssertion imple
      *            the Element from which the XmlAssertion is constructed
      */
     public XmlPrimitiveAssertion(Element element) {
-        setValue(element);
+        this.element = element;
         setOptionality(element);
         setIgnorability(element);
     }