svn commit: r1684988 - in /webservices/axiom/trunk/implementations/axiom-dom/src: main/java/org/apache/axiom/om/impl/dom/ElementImpl.java test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java

[veithen]

Author: veithen
Date: Thu Jun 11 22:25:21 2015
New Revision: 1684988

URL: http://svn.apache.org/r1684988
Log:
Make a DOM test case pass.

Modified:
    
webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
    
webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java

Modified: 
webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
URL: 
http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java?rev=1684988&r1=1684987&r2=1684988&view=diff
==============================================================================
--- 
webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
 (original)
+++ 
webservices/axiom/trunk/implementations/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
 Thu Jun 11 22:25:21 2015
@@ -752,11 +752,13 @@ public class ElementImpl extends ParentN
      * @param tempAttr
      */
     private void updateIsId(boolean isId, AttrImpl tempAttr) {
-        tempAttr.isId = isId;
-        if (isId) {
-            ownerDocument().addIdAttr(tempAttr);
-        } else {
-            ownerDocument().removeIdAttr(tempAttr);
+        if (tempAttr.isId != isId) {
+            tempAttr.isId = isId;
+            if (isId) {
+                ownerDocument().addIdAttr(tempAttr);
+            } else {
+                ownerDocument().removeIdAttr(tempAttr);
+            }
         }
     }
 

Modified: 
webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
URL: 
http://svn.apache.org/viewvc/webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java?rev=1684988&r1=1684987&r2=1684988&view=diff
==============================================================================
--- 
webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
 (original)
+++ 
webservices/axiom/trunk/implementations/axiom-dom/src/test/java/org/apache/axiom/om/impl/dom/DOMImplementationTest.java
 Thu Jun 11 22:25:21 2015
@@ -263,7 +263,6 @@ public class DOMImplementationTest exten
         builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/domstringlistitem01)");
         builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/domstringlistitem02)");
         builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/elementcontentwhitespace01)");
-        builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/elementsetidattribute10)");
         builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/elementsetidattributenode01)");
         builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/elementsetidattributenode04)");
         builder.exclude(W3CTestCase.class, 
"(id=http://www.w3.org/2001/DOM-Test-Suite/level3/core/elementsetidattributenode08)");