This is an automated email from the ASF dual-hosted git repository.
veithen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ws-axiom.git
The following commit(s) were added to refs/heads/master by this push:
new f0de098 Set up ErrorProne
f0de098 is described below
commit f0de09879a4449c6595f6b051ed563353436d859
Author: Andreas Veithen <[email protected]>
AuthorDate: Sat Mar 12 13:20:34 2022 +0000
Set up ErrorProne
---
.../util/stax/dialect/StAXDialectDetector.java | 3 +-
.../axiom/om/impl/traverse/OMAbstractIterator.java | 1 +
.../apache/axiom/core/impl/AttributeIterator.java | 1 +
pom.xml | 45 +++++++++++++++++++++-
.../ts/soap/header/TestExamineAllHeaderBlocks.java | 2 +-
.../TestExamineAllHeaderBlocksWithParser.java | 2 +-
.../ts/soap/header/TestExamineHeaderBlocks.java | 2 +-
.../TestExamineMustUnderstandHeaderBlocks.java | 2 +-
8 files changed, 52 insertions(+), 6 deletions(-)
diff --git
a/axiom-api/src/main/java/org/apache/axiom/util/stax/dialect/StAXDialectDetector.java
b/axiom-api/src/main/java/org/apache/axiom/util/stax/dialect/StAXDialectDetector.java
index 8259c27..e6e7931 100644
---
a/axiom-api/src/main/java/org/apache/axiom/util/stax/dialect/StAXDialectDetector.java
+++
b/axiom-api/src/main/java/org/apache/axiom/util/stax/dialect/StAXDialectDetector.java
@@ -307,7 +307,8 @@ public class StAXDialectDetector {
return null;
}
}
-
+
+ @SuppressWarnings("ReturnValueIgnored")
private static StAXDialect detectDialectFromClasses(ClassLoader
classLoader, URL rootUrl) {
Class<?> cls;
diff --git
a/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMAbstractIterator.java
b/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMAbstractIterator.java
index 10d92db..f3007d3 100644
---
a/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMAbstractIterator.java
+++
b/axiom-compat/src/main/java/org/apache/axiom/om/impl/traverse/OMAbstractIterator.java
@@ -90,6 +90,7 @@ public abstract class OMAbstractIterator implements Iterator {
}
@Override
+ @SuppressWarnings("ReturnValueIgnored")
public void remove() {
if (!nextCalled) {
throw new IllegalStateException("next() has not yet been called");
diff --git
a/mixins/core-mixins/src/main/java/org/apache/axiom/core/impl/AttributeIterator.java
b/mixins/core-mixins/src/main/java/org/apache/axiom/core/impl/AttributeIterator.java
index 6e56569..97604bb 100644
---
a/mixins/core-mixins/src/main/java/org/apache/axiom/core/impl/AttributeIterator.java
+++
b/mixins/core-mixins/src/main/java/org/apache/axiom/core/impl/AttributeIterator.java
@@ -87,6 +87,7 @@ public final class AttributeIterator<T extends CoreAttribute,
S> implements Iter
}
@Override
+ @SuppressWarnings("ReturnValueIgnored")
public final void remove() {
if (currentAttribute == null) {
throw new IllegalStateException();
diff --git a/pom.xml b/pom.xml
index 2c6ec7d..168417e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -264,7 +264,8 @@
<jaxbri.version>2.3.6</jaxbri.version>
<auto-service.version>1.0.1</auto-service.version>
<asm.version>9.2</asm.version>
-
+ <errorprone.version>2.11.0</errorprone.version>
+
<skipDeploy>false</skipDeploy>
<project.build.outputTimestamp>2021-12-19T15:46:00Z</project.build.outputTimestamp>
@@ -736,6 +737,19 @@
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.10.1</version>
+ <configuration>
+ <compilerArgs combine.children="append">
+ <compilerArg>-XDcompilePolicy=simple</compilerArg>
+ <compilerArg>-Xplugin:ErrorProne</compilerArg>
+ </compilerArgs>
+ <annotationProcessorPaths combine.children="append">
+ <annotationProcessorPath>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>${errorprone.version}</version>
+ </annotationProcessorPath>
+ </annotationProcessorPaths>
+ </configuration>
</plugin>
<plugin>
<artifactId>maven-jar-plugin</artifactId>
@@ -1234,6 +1248,35 @@ $${type_declaration}</template></templates>]]></value>
<profiles>
<profile>
+ <id>jdk16</id>
+ <activation>
+ <jdk>[16,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <fork>true</fork>
+ <compilerArgs combine.children="append">
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED</compilerArg>
+
<compilerArg>-J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED</compilerArg>
+ </compilerArgs>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
<id>apache-release</id>
<build>
<plugins>
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocks.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocks.java
index bfb1be5..695508c 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocks.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocks.java
@@ -41,7 +41,7 @@ public class TestExamineAllHeaderBlocks extends SOAPTestCase {
soapHeader.addHeaderBlock("echoOk1", namespace);
soapHeader.addHeaderBlock("echoOk2", namespace);
Iterator<SOAPHeaderBlock> iterator =
soapHeader.examineAllHeaderBlocks();
- iterator.hasNext();
+ assertTrue(iterator.hasNext());
SOAPHeaderBlock headerBlock1 = iterator.next();
assertNotNull(
"SOAP Header Test : - After calling addHeaderBlock method
twice, examineAllHeaderBlocks method returns empty iterator",
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocksWithParser.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocksWithParser.java
index 54ba8a8..b169579 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocksWithParser.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineAllHeaderBlocksWithParser.java
@@ -35,7 +35,7 @@ public class TestExamineAllHeaderBlocksWithParser extends
SampleBasedSOAPTestCas
@Override
protected void runTest(SOAPEnvelope envelope) throws Throwable {
Iterator<SOAPHeaderBlock> iterator =
envelope.getHeader().examineAllHeaderBlocks();
- iterator.hasNext();
+ assertTrue(iterator.hasNext());
SOAPHeaderBlock headerBlock = iterator.next();
assertEquals("MessageID", headerBlock.getLocalName());
assertTrue(iterator.hasNext());
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineHeaderBlocks.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineHeaderBlocks.java
index dc82b63..5d5296a 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineHeaderBlocks.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/header/TestExamineHeaderBlocks.java
@@ -42,7 +42,7 @@ public class TestExamineHeaderBlocks extends SOAPTestCase {
soapHeader.addHeaderBlock("echoOk1",
namespace).setRole("urn:test-role");
soapHeader.addHeaderBlock("echoOk2", namespace).setRole(roleNextURI);
Iterator<SOAPHeaderBlock> iterator =
soapHeader.examineHeaderBlocks(roleNextURI);
- iterator.hasNext();
+ assertTrue(iterator.hasNext());
SOAPHeaderBlock headerBlockWithRole = iterator.next();
assertEquals(
"SOAP Header Test : - headerBlockWithRole local name mismatch",
diff --git
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/header/TestExamineMustUnderstandHeaderBlocks.java
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/header/TestExamineMustUnderstandHeaderBlocks.java
index 3a1afca..4f3de33 100644
---
a/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/header/TestExamineMustUnderstandHeaderBlocks.java
+++
b/testing/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap12/header/TestExamineMustUnderstandHeaderBlocks.java
@@ -52,7 +52,7 @@ public class TestExamineMustUnderstandHeaderBlocks extends
SOAPTestCase {
Iterator iterator = soapHeader.examineMustUnderstandHeaderBlocks(
"http://www.w3.org/2003/05/soap-envelope/role/ultimateReceiver";);
- iterator.hasNext();
+ assertTrue(iterator.hasNext());
SOAPHeaderBlock headerBlock = (SOAPHeaderBlock) iterator.next();
assertFalse(
"SOAP Header Test : - examineMustUnderstandHeaderBlocks method
returns empty iterator",
