ashvina commented on code in PR #357:
URL: https://github.com/apache/incubator-xtable/pull/357#discussion_r1509778301
##########
core/pom.xml:
##########
@@ -115,11 +115,6 @@
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_${scala.version.prefix}</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-common</artifactId>
- <scope>test</scope>
Review Comment:
Thanks for catching and fixing the duplicate dependency. However, the two
dependencies have different scopes. The tests still pass if the other one is
removed. However, I am uncertain if the bundled jar (cli) would function, since
hadoop-common has a provided scope in the parent. What do you think is the
appropriate scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
