zabetak commented on code in PR #352: URL: https://github.com/apache/incubator-xtable/pull/352#discussion_r1510890894
########## website/blog/OneTable-is-now-Apache-XTable.md: ########## @@ -0,0 +1,67 @@ +--- +title: "OneTable is now “Apache XTable (Incubating)”" +excerpt: "XTable is now Incubating in the Apache Software Foundation" +author: Dipankar Mazumdar, JB Onofré +category: blog +image: /images/blog/XTable/xtable-cover.png +tags: +- apache xtable +- community +--- + +# OneTable is now “Apache XTable (Incubating)” Review Comment: The incubation [publishing guide](https://incubator.apache.org/guides/branding.html) writes the following. ``` A podling and affiliated persons can issue press releases that reference the podling, but cannot issue press releases with the specific intent of announcing the podling. The podling can conduct informal PR activities such as media outreach, blog publicity, etc. The ASF will not issue any press releases for any podling at this stage. The [Apache Press Team](http://www.apache.org/press/index.html#whoweare) MUST review any releases by affiliated organizations or groups to ensure they comply with our branding guidelines. ``` From the above I assume that this blog post is fine as it is but be mindful about the above guidelines if you plan to make follow-up announcements. ########## website/static/index.html: ########## @@ -3,13 +3,13 @@ <html data-wf-page="65402b66d39d6454e51fabf1" data-wf-site="65402b66d39d6454e51fabed"> <head> <meta charset="utf-8"> - <title>OneTable</title> - <meta content="OneTable is an omni-directional interop of lakehouse table formats Apache Hudi, Apache Iceberg, and Delta Lake. OneTable is NOT a new or separate format, OneTable provides abstractions and tools for the translation of lakehouse table format metadata." name="description"> - <meta content="OneTable" property="og:title"> - <meta content="OneTable is an omni-directional interop of lakehouse table formats Apache Hudi, Apache Iceberg, and Delta Lake. OneTable is NOT a new or separate format, OneTable provides abstractions and tools for the translation of lakehouse table format metadata." property="og:description"> + <title>XTable</title> Review Comment: The title should be "Apache XTable™" as well as the other prominent references to XTable in this page. ########## website/static/images/destination1.svg: ########## @@ -1,3 +1,19 @@ +<!--Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License.--> Review Comment: In various cases this kind of icons come from commercial templates that are already under some kind of LICENSE. Depending on the LICENSE it may not be appropriate to re-license them under AL2. If you created them yourself then its fine to add the header otherwise we should leave them as is and open a separate ticket to see if following actions are needed. In fact, we may need to open a separate ticket anyways to review all image related content. ########## website/docusaurus.config.js: ########## @@ -6,8 +6,8 @@ const darkCodeTheme = require('prism-react-renderer/themes/dracula'); /** @type {import('@docusaurus/types').Config} */ const config = { - title: 'OneTable', - favicon: 'images/onetable_favicon.png', + title: 'XTable', Review Comment: I guess references here should also be "Apache XTable™" ########## website/static/images/xtable-svg.svg: ########## @@ -0,0 +1,70 @@ +<svg width="554" height="150" viewBox="0 0 554 150" fill="none" xmlns="http://www.w3.org/2000/svg";> Review Comment: Cool, then there are no LICENSE problems. Nevertheless, since this is a new logo for the project it would be best to start a VOTE thread in the dev@xtable list before putting this officially online to ensure that there are no objections from the PMC. Can you please start the respective thread? (If you are not familiar with the process I can do that for you) Other than that the logo must contain also the TM symbol as per [policy](https://www.apache.org/foundation/marks/pmcs#graphics). Finally, but not blocking for this PR the logo(s) should be submitted in https://www.apache.org/logos/ once the VOTE passes. ########## website/docs/biglake-metastore.md: ########## @@ -7,33 +7,33 @@ import Tabs from '@theme/Tabs'; import TabItem from '@theme/TabItem'; # Syncing to BigLake Metastore -This document walks through the steps to register a OneTable synced Iceberg table in BigLake Metastore on GCP. +This document walks through the steps to register a XTable synced Iceberg table in BigLake Metastore on GCP. Review Comment: I think it would be better to use the full name i.e., "Apache XTable" everywhere even in doc pages (at least at the very first reference in each page). This would avoid receiving comments that the project does not follow the branding guidelines. In fact, I think that it would be even better to use "Apache XTable™" since even as part of the incubation Apache XTable is ASF trademark; I forgot to mention that in my first pass. ########## website/static/index.html: ########## @@ -228,22 +212,29 @@ <h4 class="accordion-heading"><span><strong class="faq-q">What are the future pl <div class="icon-2 accordion-icon">keyboard_arrow_down</div> </div> <div class="accordion-item-content"> - <p class="faq-a">Current contributors across Onehouse, Microsoft, Google, and others are planning to incubate OneTable into the Apache Software Foundation. Stay tuned for more updates.</p> + <p class="faq-a">Current contributors across Onehouse, Microsoft, Google, and others are planning to incubate XTable into the Apache Software Foundation. Stay tuned for more updates.</p> Review Comment: This is already done so it may be good to update this part if not now then in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
