the-other-tim-brown commented on code in PR #428:
URL: https://github.com/apache/incubator-xtable/pull/428#discussion_r1615370060
##########
core/src/main/java/org/apache/xtable/delta/DeltaConversionTarget.java:
##########
@@ -268,9 +281,23 @@ private void commitTransaction() {
}
private Map<String, String> getConfigurationsForDeltaSync() {
+
+ // The output of detail() method has only one row with the following
schema.
+ // deltaTable.detail() is added to the constructor for this class, and
sets
+ // a private variable to of deltaTable
+
+ // limit the results to the attributes needed
+ Dataset<Row> record = deltaTable.detail().select("minWriterVersion",
"minReaderVersion");
Review Comment:
It would be good to see if we can just let the Delta Lake library
automatically set the versions for us. Can you try that as well? If I remember
correctly, it looked like it would auto update them for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
