vinishjail97 commented on code in PR #539: URL: https://github.com/apache/incubator-xtable/pull/539#discussion_r1763322805
########## DISCLAIMER: ########## @@ -0,0 +1,10 @@ +Apache XTable™ (Incubating) is an effort undergoing incubation at the Apache Software +Foundation (ASF), sponsored by the Apache Incubator PMC. + +Incubation is required of all newly accepted projects until a further review Review Comment: @rangareddy Please remove this, xtable used DISCLAIMER-WIP file and we need to include this file as part of META-INF/ https://github.com/apache/incubator-xtable/blob/main/DISCLAIMER-WIP ########## pom.xml: ########## @@ -570,6 +570,10 @@ <properties> <projectName>Apache XTable (incubating)</projectName> </properties> + <resourceBundles> + <resourceBundle>org.apache:apache-jar-resource-bundle:1.4</resourceBundle> + <resourceBundle>org.apache.apache.resources:apache-incubator-disclaimer-resource-bundle:1.2-SNAPSHOT</resourceBundle> Review Comment: Can we use versions available from maven ? https://mvnrepository.com/artifact/org.apache/apache-incubator-disclaimer-resource-bundle Also can you include the version in properties ? https://github.com/apache/incubator-xtable/blob/main/pom.xml#L56 `<apache-incubator-disclaimer-resource-bundle.version>1.1</apache-incubator-disclaimer-resource-bundle.version>` Something like this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
