pjfanning commented on code in PR #541:
URL: https://github.com/apache/incubator-xtable/pull/541#discussion_r1764155144
##########
LICENSE:
##########
@@ -199,3 +199,31 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+========================================================================
Review Comment:
the changes in this PR seem unrelated to the xtable-utilities fat jar and
seem more related to the XTable source code (and are needed - but the title of
this PR seems wrong).
You also need a separate LICENSE and NOTICE for the xtable-utilities fat jar
that list all the license and notice details of the classes that you include in
that jar. There is a suspicion that some of the classes should not be in there
because they have licenses that are not compatible with the Apache license. The
OpenJDK JOL classes would seem to me that they should be removed because they
are GPL licensed. https://github.com/openjdk/jol/blob/master/LICENSE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
