rangareddy opened a new pull request, #544:
URL: https://github.com/apache/incubator-xtable/pull/544

   ## *Important Read*
   
   This pull request aims to address issues 
[#529](https://github.com/apache/incubator-xtable/issues/529)
   
   ## What is the purpose of the pull request
   
   To support building the xtable with multiple scala versions i.e 2.12 and 
2.13. 
   
   ## Brief change log
   
   * Added scala12 and scala13 version properties in pom.xml file.
   
   ```xml
   <scala12.version>2.12.15</scala12.version>
   <scala13.version>2.13.8</scala13.version>
   ```
   
   * Added profiles to support scala12 and scala13
   
   ```xml
   <!--Scala 2.12 Profile -->
   <profile>
       <id>scala-2.12</id>
       <activation>
           <activeByDefault>true</activeByDefault>
       </activation>
       <properties>
           <scala.version>${scala12.version}</scala.version>
           <scala.version.prefix>2.12</scala.version.prefix>
       </properties>
       <build>
           <pluginManagement/>
       </build>
   </profile>
   
   <!--Scala 2.13 Profile -->
   <!-- Once hudi supports scala 2.13 then enable following profile -->
   <!--<profile>
       <id>scala-2.13</id>
       <activation>
           <activeByDefault>false</activeByDefault>
       </activation>
       <properties>
           <scala.version>${scala13.version}</scala.version>
           <scala.version.prefix>2.13</scala.version.prefix>
       </properties>
       <build>
           <pluginManagement>
               <plugins>
                   <plugin>
                       <groupId>net.alchim31.maven</groupId>
                       <artifactId>scala-maven-plugin</artifactId>
                       <configuration>
                           <args>
                               <arg>-unchecked</arg>
                               <arg>-deprecation</arg>
                               <arg>-feature</arg>
                               <arg>-explaintypes</arg>
                               <arg>-target:jvm-1.8</arg>
                           </args>
                           <compilerPlugins/>
                       </configuration>
                   </plugin>
               </plugins>
           </pluginManagement>
       </build>
   </profile>-->
   ```
   
   ## Verify this pull request
   
   Run `$ mvn clean install -DskipTests -U` locally.
   
   **Note:** Hudi does not yet support Scala 2.13 jars, so the scala-2.13 
profile is commented out. Once Hudi supports Scala 2.13, we can use the 
following command to build xtable with Scala 2.13.
   
   ```sh
   mvn clean install -DskipTests -Pscala-2.13 
   ```
   
   ## References
   
   * https://github.com/apache/spark/blob/branch-3.4/pom.xml#L3617
   * https://github.com/apache/incubator-gluten/blob/main/pom.xml#L132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to