vinishjail97 commented on code in PR #591:
URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1883074786
##########
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalTable.java:
##########
@@ -38,6 +40,8 @@ class ExternalTable {
protected final @NonNull String formatName;
/** The path to the root of the table or the metadata directory depending on
the format */
protected final @NonNull String basePath;
+ /** The path to the data files, defaults to the metadataPath */
+ protected final @NonNull String dataPath;
Review Comment:
I have done this for easy conversion between `SourceTable` and
`TargetTable`, but now that I think of it I will try to change the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
