vinishjail97 commented on code in PR #591: URL: https://github.com/apache/incubator-xtable/pull/591#discussion_r1899956299
########## xtable-core/src/main/java/org/apache/xtable/catalog/CatalogConversionFactory.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.xtable.catalog; + +import org.apache.hadoop.conf.Configuration; + +import org.apache.xtable.conversion.ExternalCatalogConfig; +import org.apache.xtable.reflection.ReflectionUtils; +import org.apache.xtable.spi.extractor.CatalogConversionSource; +import org.apache.xtable.spi.sync.CatalogSyncClient; + +public class CatalogConversionFactory { + private static final CatalogConversionFactory INSTANCE = new CatalogConversionFactory(); + + public static CatalogConversionFactory getInstance() { + return INSTANCE; + } + + /** + * Returns an implementation class for {@link CatalogConversionSource} that's used for converting + * table definitions in the catalog to {@link org.apache.xtable.conversion.SourceTable} object. + * + * @param sourceCatalogConfig configuration for the source catalog + * @param configuration hadoop configuration + */ + public static CatalogConversionSource createCatalogConversionSource( + ExternalCatalogConfig sourceCatalogConfig, Configuration configuration) { + return ReflectionUtils.createInstanceOfClass( + sourceCatalogConfig.getCatalogConversionSourceImpl(), sourceCatalogConfig, configuration); + } + + /** + * Returns an implementation class for {@link CatalogSyncClient} that's used for syncing {@link + * org.apache.xtable.conversion.TargetTable} to a catalog. + * + * @param targetCatalogConfig configuration for the target catalog + * @param configuration hadoop configuration + */ + public CatalogSyncClient createCatalogSyncClient( Review Comment: There's another function which uses `Map<CatalogTableIdentifier, CatalogSyncClient> catalogSyncClients` as one of it's argument skipping it because there can be multiple types in the values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
