ashvina commented on code in PR #627:
URL: https://github.com/apache/incubator-xtable/pull/627#discussion_r1929494629
##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaActionsConverter.java:
##########
@@ -115,16 +121,45 @@ static String getFullPathToFile(Snapshot snapshot, String
dataFilePath) {
*
* @param snapshot the commit snapshot
* @param addFile the add file action
- * @return the deletion vector representation (path of data file), or null
if no deletion vector
- * is present
+ * @return the deletion vector representation, or null if no deletion vector
is present
*/
- public String extractDeletionVectorFile(Snapshot snapshot, AddFile addFile) {
+ public InternalDeletionVector extractDeletionVector(Snapshot snapshot,
AddFile addFile) {
DeletionVectorDescriptor deletionVector = addFile.deletionVector();
if (deletionVector == null) {
return null;
}
String dataFilePath = addFile.path();
- return getFullPathToFile(snapshot, dataFilePath);
+ dataFilePath = getFullPathToFile(snapshot, dataFilePath);
+ Path deletionVectorFilePath =
deletionVector.absolutePath(snapshot.deltaLog().dataPath());
+
+ // TODO assumes deletion vector file. Need to handle inlined deletion
vectors
Review Comment:
Resolved by adding support for inlined delete vectors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
