the-other-tim-brown commented on code in PR #632:
URL: https://github.com/apache/incubator-xtable/pull/632#discussion_r1937335991
##########
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalCatalogConfig.java:
##########
@@ -61,5 +61,5 @@ public class ExternalCatalogConfig {
/**
* The properties for this catalog, used for providing any custom behaviour
during catalog sync
*/
- @NonNull @Builder.Default Map<String, String> catalogProperties =
Collections.emptyMap();
Review Comment:
The preference is to keep it as an empty map instead of null so that we
reduce risk of NPEs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
