the-other-tim-brown commented on code in PR #638:
URL: https://github.com/apache/incubator-xtable/pull/638#discussion_r1943407907
##########
pom.xml:
##########
@@ -291,7 +292,6 @@
<groupId>io.delta</groupId>
<artifactId>delta-standalone_${scala.binary.version}</artifactId>
<version>${delta.standalone.version}</version>
- <scope>test</scope>
Review Comment:
Why does the scope of this need to change? This dependency is deprecated so
if we need to use it in non-test code we should consider switching to
delta-kernel
##########
xtable-hive-metastore/pom.xml:
##########
@@ -49,6 +49,13 @@
<version>${iceberg.version}</version>
</dependency>
+ <!-- Delta dependencies -->
+ <dependency>
+ <groupId>io.delta</groupId>
+ <artifactId>delta-hive_${scala.binary.version}</artifactId>
+ <version>${delta.hive.version}</version>
Review Comment:
Let's declare this in the depenency-management section of the parent pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
