kroushan-nit commented on code in PR #637:
URL: https://github.com/apache/incubator-xtable/pull/637#discussion_r1945229402
##########
xtable-aws/src/main/java/org/apache/xtable/glue/GlueSchemaExtractor.java:
##########
@@ -231,4 +233,42 @@ protected String toTypeString(InternalSchema fieldSchema,
String tableFormat) {
protected static String getColumnProperty(String tableFormat, String
property) {
return String.format("%s.%s", tableFormat.toLowerCase(Locale.ENGLISH),
property);
}
+
+ @VisibleForTesting
+ public List<Column> getNonPartitionColumns(InternalTable table, Map<String,
Column> columnsMap) {
+ List<String> partitionKeys = getPartitionKeys(table);
+ return columnsMap.values().stream()
+ .filter(c -> !partitionKeys.contains(c.name()))
+ .collect(Collectors.toList());
+ }
+
+ @VisibleForTesting
+ public List<Column> getPartitionColumns(InternalTable table, Map<String,
Column> columnsMap) {
+ /**
+ * When converting delta schema to InternalSchema, generated columns are
excluded: {@link
Review Comment:
Created a github issue to track this:
https://github.com/apache/incubator-xtable/issues/642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
