vamsikarnika commented on code in PR #648:
URL: https://github.com/apache/incubator-xtable/pull/648#discussion_r1957738203


##########
xtable-utilities/src/test/resources/catalogConfig.yaml:
##########
@@ -45,6 +45,7 @@ datasets:
   - sourceCatalogTableIdentifier:
       tableIdentifier:
         hierarchicalId: "source-database-1.source-1"
+        partitionSpec: "cs_sold_date_sk:VALUE"

Review Comment:
   Yes, We also need partitionSpec when target is HUDI, since during 
catalogSync we convert target table to source table before syncing to catalogs.



##########
xtable-utilities/src/test/resources/catalogConfig.yaml:
##########
@@ -45,6 +45,7 @@ datasets:
   - sourceCatalogTableIdentifier:
       tableIdentifier:
         hierarchicalId: "source-database-1.source-1"
+        partitionSpec: "cs_sold_date_sk:VALUE"

Review Comment:
   We also need partitionSpec when target is HUDI, since during catalogSync we 
convert target table to source table before syncing to catalogs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to