the-other-tim-brown commented on code in PR #653:
URL: https://github.com/apache/incubator-xtable/pull/653#discussion_r1960700673
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDataFile.java:
##########
@@ -33,17 +38,18 @@
*
* @since 0.1
*/
-@Builder(toBuilder = true)
-@Value
-public class InternalDataFile {
- // physical path of the file (absolute with scheme)
- @NonNull String physicalPath;
+@SuperBuilder(toBuilder = true)
+@FieldDefaults(makeFinal = true, level = lombok.AccessLevel.PRIVATE)
+@ToString(callSuper = true)
+@EqualsAndHashCode(callSuper = true)
+@Accessors(fluent = true)
Review Comment:
Let's keep with the current patterns for now and keep the style changes
separate from the deletion vector changes. This is already a breaking change so
I would prefer we aim to keep the surface area as small as possible right now
so users can avoid having to update so many places in their code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
