the-other-tim-brown commented on code in PR #650:
URL: https://github.com/apache/incubator-xtable/pull/650#discussion_r2007993094
##########
xtable-api/src/main/java/org/apache/xtable/model/stat/ColumnStat.java:
##########
@@ -36,4 +38,7 @@ public class ColumnStat {
long numNulls;
long numValues;
long totalSize;
+ long uncompressedSize;
+ Set<Encoding> encodings;
+ Statistics statistics;
Review Comment:
I don't think we need to add these since they are not used by the other
table formats. This also introduces parquet specific dependencies into the
model which we should avoid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
