the-other-tim-brown commented on code in PR #670:
URL: https://github.com/apache/incubator-xtable/pull/670#discussion_r2021617484
##########
xtable-api/src/main/java/org/apache/xtable/model/schema/InternalPartitionField.java:
##########
@@ -47,4 +49,6 @@ public class InternalPartitionField {
@Builder.Default List<String> partitionFieldNames = Collections.emptyList();
// An enum describing how the source data was transformed into the partition
value
PartitionTransformType transformType;
+ // Transform options such as number of buckets in the BUCKET transform type
+ @Builder.Default Map<String, Object> transformOptions =
Collections.emptyMap();
Review Comment:
Right now, I made this similar to the `metadata` in `InternalSchema`.
Another option I considered is to change `PartitionTransformType` into a class
which can then have its own instance variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
