unical1988 commented on code in PR #669:
URL: https://github.com/apache/incubator-xtable/pull/669#discussion_r2052898303
##########
xtable-api/src/main/java/org/apache/xtable/model/storage/InternalDataFile.java:
##########
@@ -52,4 +52,21 @@ public class InternalDataFile extends InternalFile {
@Builder.Default @NonNull List<ColumnStat> columnStats =
Collections.emptyList();
// last modified time in millis since epoch
long lastModified;
+ public static InternalDataFileBuilder builderFrom(InternalDataFile dataFile)
{
+ return dataFile.toBuilder();
+ }
+
+ public boolean equals(InternalDataFile obj2) {
Review Comment:
the list comparison generated with delombok for columnStats is the the
following:
`if (this$columnStats == null ? other$columnStats != null :
!this$columnStats.equals(other$columnStats)) return false;` whereas the working
test I implement is the following:
`
```
IntStream.range(0, this.getColumnStats().size())
.allMatch(i ->
this.getColumnStats().get(i).equals(obj2.getColumnStats().get(i)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
