vinishjail97 commented on issue #701: URL: https://github.com/apache/incubator-xtable/issues/701#issuecomment-2840759264
Based on vote thread from @jbonofre. ``` - NOK: DISCLAIMER-WIP is here, but it would be great to list why it's still WIP (for instance, "Contains code that may not be compatible with the Apache License" or so). Else it should be DISCLAIMER. - NOK: LICENSE is there in the source distribution, but it should mention that xtable-core/src/main/java/org/apache/xtable/hudi/HudiInstantUtils.java contains code directly copied from org.apache.hudi.common.table.timeline.HoodieActiveTimeline ``` hudi is a top-level ASF project and this guidance from ASF team mentions it's not recommended to include these dependencies. @zabetak @jbonofre Is this okay? https://issues.apache.org/jira/browse/LEGAL-684 ``` - NOK: xtable-aws bundle jar includes a LICENSE file but AWS SDK is not documented here. NOTICE should also include AWS SDK NOTICE (as it's ALv2 dep). - NOK: xtable-hive-metastore jar includes a LICENSE file but Guava, Avro, Scala, Caffeine, RoaringBitmap, HttpClient, RocksDB, HBase, javassist are not listed (same for the NOTICE file). - NOK: xtable-hudi-support extension jar includes a LICENSE but Jackson, log4j, guava, scala, j2objc, iceberg, delta, spark-sql, caffeine, RoaringBitmap are not listed (same for the NOTICE file). ``` I will put up a PR for these license updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
