vinishjail97 commented on code in PR #705: URL: https://github.com/apache/incubator-xtable/pull/705#discussion_r2067829803
########## spec/rest-service-open-api.yaml: ########## @@ -0,0 +1,241 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +openapi: 3.0.3 +info: + title: XTable REST Service API + license: + name: Apache 2.0 + url: https://www.apache.org/licenses/LICENSE-2.0.html + version: 0.0.1 + description: | + A REST API for initiating metadata conversion using Apache XTable. + +servers: + - url: "{scheme}://{host}/{prefix}" + description: Server URL when the port can be inferred from the scheme + variables: + scheme: + description: The scheme of the URI, either http or https. + default: https + host: + description: The host address for the specified server + default: localhost + prefix: + description: Optional prefix to be appended to all routes + default: "" + - url: "{scheme}://{host}:{port}/{prefix}" + description: Generic base server URL, with all parts configurable + variables: + scheme: + description: The scheme of the URI, either http or https. + default: https + host: + description: The host address for the specified server + default: localhost + port: + description: The port used when addressing the host + default: "8080" + prefix: + description: Optional prefix to be appended to all routes + default: "" + +paths: + /v1/conversion/table: + post: + tags: + - XTable Service API + summary: Initiate XTable's runSync process to convert a source table format to the requested target table formats. + description: | + Reads the source table metadata from storage, converts it to the requested + target formats. + operationId: convertTable Review Comment: `operationId: convertTable` What does this mean in the spec? A comment would be helpful. ########## spec/Makefile: ########## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements… +# (your license header…) + +PYTHON := python3 Review Comment: Which files does this generate for the spec? Will the server implementation can use the generated spec file? https://github.com/apache/polaris/tree/main/spec#generated-specification-files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
