the-other-tim-brown commented on code in PR #669:
URL: https://github.com/apache/incubator-xtable/pull/669#discussion_r2070994895
##########
xtable-utilities/src/main/java/org/apache/xtable/utilities/RunCatalogSync.java:
##########
@@ -131,11 +132,11 @@ public static void main(String[] args) throws Exception {
Paths.get(cmd.getOptionValue(CATALOG_SOURCE_AND_TARGET_CONFIG_PATH)))) {
datasetConfig = YAML_MAPPER.readValue(inputStream, DatasetConfig.class);
}
-
- byte[] customConfig = getCustomConfigurations(cmd, HADOOP_CONFIG_PATH);
+ String hadoopConfigpath = getValueFromConfig(cmd, HADOOP_CONFIG_PATH);
+ byte[] customConfig = getCustomConfigurations(hadoopConfigpath);
Configuration hadoopConf = loadHadoopConf(customConfig);
-
- customConfig = getCustomConfigurations(cmd, CONVERTERS_CONFIG_PATH);
+ String conversionProviderConfigpath = getValueFromConfig(cmd,
CONVERTERS_CONFIG_PATH);
+ customConfig = getCustomConfigurations(conversionProviderConfigpath);
Review Comment:
Can you try syncing your fork's master branch to see if that cleans up the
diff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
