vinishjail97 commented on PR #707: URL: https://github.com/apache/incubator-xtable/pull/707#issuecomment-2856594883
> @vinishjail97 you are adding non ASF projects in the `LICENSE` (like Jackson). If I agree that it's not needed to add `NOTICE` content for ASF dependencies, `NOTICE` content for ALv2 dependencies (third parties) should be checked and included in the `NOTICE`. > > Assuming that the bundled dependency itself contains no bundled sub-components under other licenses, so the ALv2 applies uniformly to all files, there is no need to modify LICENSE. However, for completeness it is useful to list the products and their versions, as is done for products under other licenses. If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file. > > So, if you checked the content and you are good with that, it's fine for me. @zabetak @jcamachor Can you confirm/ack this as well? I would like to get the dev vote thread aligned and pass easily for rc3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
