This is an automated email from the ASF dual-hosted git repository. vinish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-xtable.git
The following commit(s) were added to refs/heads/main by this push: new d478d2e3 Fix typo in InternalTable (#720) d478d2e3 is described below commit d478d2e3355b5c6ba6562aaff48b0c3b0e0a76d1 Author: Vinish Reddy <vinishreddygunne...@gmail.com> AuthorDate: Sat May 31 23:52:44 2025 +0530 Fix typo in InternalTable (#720) --- xtable-api/src/main/java/org/apache/xtable/model/InternalTable.java | 2 +- .../src/main/java/org/apache/xtable/delta/DeltaTableExtractor.java | 2 +- .../src/main/java/org/apache/xtable/hudi/HudiTableExtractor.java | 2 +- .../java/org/apache/xtable/iceberg/IcebergConversionSource.java | 2 +- .../test/java/org/apache/xtable/delta/ITDeltaConversionSource.java | 6 +++--- .../test/java/org/apache/xtable/hudi/ITHudiConversionSource.java | 2 +- .../src/test/java/org/apache/xtable/testutil/ITTestUtils.java | 2 +- .../src/main/java/org/apache/xtable/service/ConversionService.java | 2 +- .../test/java/org/apache/xtable/service/TestConversionService.java | 6 +++--- 9 files changed, 13 insertions(+), 13 deletions(-) diff --git a/xtable-api/src/main/java/org/apache/xtable/model/InternalTable.java b/xtable-api/src/main/java/org/apache/xtable/model/InternalTable.java index 8575ee81..4fadbb07 100644 --- a/xtable-api/src/main/java/org/apache/xtable/model/InternalTable.java +++ b/xtable-api/src/main/java/org/apache/xtable/model/InternalTable.java @@ -51,5 +51,5 @@ public class InternalTable { // latest commit(write) on the table. Instant latestCommitTime; // Path to latest metadata - String latestMetdataPath; + String latestMetadataPath; } diff --git a/xtable-core/src/main/java/org/apache/xtable/delta/DeltaTableExtractor.java b/xtable-core/src/main/java/org/apache/xtable/delta/DeltaTableExtractor.java index 1929974e..731b5c30 100644 --- a/xtable-core/src/main/java/org/apache/xtable/delta/DeltaTableExtractor.java +++ b/xtable-core/src/main/java/org/apache/xtable/delta/DeltaTableExtractor.java @@ -62,7 +62,7 @@ public class DeltaTableExtractor { .partitioningFields(partitionFields) .readSchema(schema) .latestCommitTime(Instant.ofEpochMilli(snapshot.timestamp())) - .latestMetdataPath(snapshot.deltaLog().logPath().toString()) + .latestMetadataPath(snapshot.deltaLog().logPath().toString()) .build(); } } diff --git a/xtable-core/src/main/java/org/apache/xtable/hudi/HudiTableExtractor.java b/xtable-core/src/main/java/org/apache/xtable/hudi/HudiTableExtractor.java index dd5996a7..795f651c 100644 --- a/xtable-core/src/main/java/org/apache/xtable/hudi/HudiTableExtractor.java +++ b/xtable-core/src/main/java/org/apache/xtable/hudi/HudiTableExtractor.java @@ -87,7 +87,7 @@ public class HudiTableExtractor { .partitioningFields(partitionFields) .readSchema(canonicalSchema) .latestCommitTime(HudiInstantUtils.parseFromInstantTime(commit.getTimestamp())) - .latestMetdataPath(metaClient.getMetaPath().toString()) + .latestMetadataPath(metaClient.getMetaPath().toString()) .build(); } diff --git a/xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java b/xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java index fe28be0d..7a777ddb 100644 --- a/xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java +++ b/xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java @@ -131,7 +131,7 @@ public class IcebergConversionSource implements ConversionSource<Snapshot> { .latestCommitTime(Instant.ofEpochMilli(snapshot.timestampMillis())) .readSchema(irSchema) .layoutStrategy(dataLayoutStrategy) - .latestMetdataPath(iceOps.current().metadataFileLocation()) + .latestMetadataPath(iceOps.current().metadataFileLocation()) .build(); } diff --git a/xtable-core/src/test/java/org/apache/xtable/delta/ITDeltaConversionSource.java b/xtable-core/src/test/java/org/apache/xtable/delta/ITDeltaConversionSource.java index 0685e919..3a754e27 100644 --- a/xtable-core/src/test/java/org/apache/xtable/delta/ITDeltaConversionSource.java +++ b/xtable-core/src/test/java/org/apache/xtable/delta/ITDeltaConversionSource.java @@ -188,7 +188,7 @@ public class ITDeltaConversionSource { .build(), DataLayoutStrategy.FLAT, "file:" + basePath, - snapshot.getTable().getLatestMetdataPath(), + snapshot.getTable().getLatestMetadataPath(), Collections.emptyList()); // Validate data files List<ColumnStat> columnStats = Arrays.asList(COL1_COLUMN_STAT, COL2_COLUMN_STAT); @@ -245,7 +245,7 @@ public class ITDeltaConversionSource { .build(), DataLayoutStrategy.FLAT, "file:" + basePath, - internalTable.getLatestMetdataPath(), + internalTable.getLatestMetadataPath(), Collections.emptyList()); } @@ -297,7 +297,7 @@ public class ITDeltaConversionSource { .build(), DataLayoutStrategy.HIVE_STYLE_PARTITION, "file:" + basePath, - snapshot.getTable().getLatestMetdataPath(), + snapshot.getTable().getLatestMetadataPath(), Collections.singletonList( InternalPartitionField.builder() .sourceField(partCol) diff --git a/xtable-core/src/test/java/org/apache/xtable/hudi/ITHudiConversionSource.java b/xtable-core/src/test/java/org/apache/xtable/hudi/ITHudiConversionSource.java index 6b6349cc..5dd00174 100644 --- a/xtable-core/src/test/java/org/apache/xtable/hudi/ITHudiConversionSource.java +++ b/xtable-core/src/test/java/org/apache/xtable/hudi/ITHudiConversionSource.java @@ -219,7 +219,7 @@ public class ITHudiConversionSource { internalSchema, DataLayoutStrategy.FLAT, "file:" + basePath + "_v1", - internalTable.getLatestMetdataPath(), + internalTable.getLatestMetadataPath(), Collections.emptyList()); } } diff --git a/xtable-core/src/test/java/org/apache/xtable/testutil/ITTestUtils.java b/xtable-core/src/test/java/org/apache/xtable/testutil/ITTestUtils.java index 4b1dac84..a5f20d6b 100644 --- a/xtable-core/src/test/java/org/apache/xtable/testutil/ITTestUtils.java +++ b/xtable-core/src/test/java/org/apache/xtable/testutil/ITTestUtils.java @@ -53,7 +53,7 @@ public class ITTestUtils { Assertions.assertEquals(readSchema, internalTable.getReadSchema()); Assertions.assertEquals(dataLayoutStrategy, internalTable.getLayoutStrategy()); Assertions.assertEquals(basePath, internalTable.getBasePath()); - Assertions.assertEquals(latestMetadataPath, internalTable.getLatestMetdataPath()); + Assertions.assertEquals(latestMetadataPath, internalTable.getLatestMetadataPath()); Assertions.assertEquals(partitioningFields, internalTable.getPartitioningFields()); } diff --git a/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java b/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java index 7d19512a..a057c1a3 100644 --- a/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java +++ b/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java @@ -238,7 +238,7 @@ public class ConversionService { ConvertedTable.builder() .targetFormat(internalTable.getTableFormat()) .targetSchema(schemaString) - .targetMetadataPath(internalTable.getLatestMetdataPath()) + .targetMetadataPath(internalTable.getLatestMetadataPath()) .build()); } return new ConvertTableResponse(convertedTables); diff --git a/xtable-service/src/test/java/org/apache/xtable/service/TestConversionService.java b/xtable-service/src/test/java/org/apache/xtable/service/TestConversionService.java index 465b1c4c..04fdfa23 100644 --- a/xtable-service/src/test/java/org/apache/xtable/service/TestConversionService.java +++ b/xtable-service/src/test/java/org/apache/xtable/service/TestConversionService.java @@ -123,7 +123,7 @@ class TestConversionService { when(conversionSrc.getCurrentTable()).thenReturn(internalTbl); when(internalTbl.getTableFormat()).thenReturn(TableFormat.HUDI); - when(internalTbl.getLatestMetdataPath()).thenReturn(HUDI_META_PATH); + when(internalTbl.getLatestMetadataPath()).thenReturn(HUDI_META_PATH); when(internalTbl.getReadSchema()).thenReturn(internalSchema); AvroSchemaConverter converter = mock(AvroSchemaConverter.class); @@ -161,7 +161,7 @@ class TestConversionService { when(conversionSrc.getCurrentTable()).thenReturn(internalTbl); when(internalTbl.getTableFormat()).thenReturn(TableFormat.ICEBERG); - when(internalTbl.getLatestMetdataPath()).thenReturn(ICEBERG_META_PATH); + when(internalTbl.getLatestMetadataPath()).thenReturn(ICEBERG_META_PATH); when(internalTbl.getReadSchema()).thenReturn(internalSchema); IcebergSchemaExtractor extractor = mock(IcebergSchemaExtractor.class); @@ -199,7 +199,7 @@ class TestConversionService { when(conversionSrc.getCurrentTable()).thenReturn(internalTbl); when(internalTbl.getTableFormat()).thenReturn(TableFormat.DELTA); - when(internalTbl.getLatestMetdataPath()).thenReturn(DELTA_META_PATH); + when(internalTbl.getLatestMetadataPath()).thenReturn(DELTA_META_PATH); when(internalTbl.getReadSchema()).thenReturn(internalSchema); SparkSchemaExtractor extractor = mock(SparkSchemaExtractor.class);