the-other-tim-brown commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2269603275
##########
xtable-core/src/main/java/org/apache/xtable/reflection/ReflectionUtils.java:
##########
@@ -43,17 +44,31 @@ public static <T> T createInstanceOfClass(String className,
Object... constructo
if (constructorArgs.length == 0) {
return clazz.newInstance();
}
- Class<?>[] constructorArgTypes =
+ /*Class<?>[] constructorArgTypes =
Review Comment:
The caller in HudiSourceConfig needs to be updated to account for the change
in args to the constructor. Update `loadSourcePartitionSpecExtractor` to:
```
try {
return
ReflectionUtils.createInstanceOfClass(partitionSpecExtractorClass,
this.getPartitionFieldSpecs());
} catch (ConfigurationException ex) {
// try legacy arguments
return
ReflectionUtils.createInstanceOfClass(partitionSpecExtractorClass, this);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
