the-other-tim-brown commented on code in PR #728:
URL: https://github.com/apache/incubator-xtable/pull/728#discussion_r2346974046
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergPartitionValueConverter.java:
##########
@@ -190,17 +190,20 @@ public PartitionKey toIceberg(
if (partitionValues == null || partitionValues.isEmpty()) {
return null;
}
- Map<String, PartitionValue> nameToPartitionInfo =
+ Map<String, List<PartitionValue>> nameToPartitionInfoList =
Review Comment:
We did not agree on this approach. I also noted that the test passes but
produces the wrong output. The code for the other formats does not change
because of the introduction of a new source. I have been saying this from the
beginning when you tried to force all targets to be aware of the source format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@xtable.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
