the-other-tim-brown commented on code in PR #760:
URL: https://github.com/apache/incubator-xtable/pull/760#discussion_r2561133114
##########
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergDataFileUpdatesSync.java:
##########
@@ -107,13 +153,95 @@ private void applyDiff(
private DataFile getDataFile(
PartitionSpec partitionSpec, Schema schema, InternalDataFile dataFile) {
+ // Convert Iceberg schema to InternalSchema for stats extraction
+ InternalSchema internalSchema =
IcebergSchemaExtractor.getInstance().fromIceberg(schema);
+
+ // Get existing stats and check if they are complete
+ List<ColumnStat> existingStats = dataFile.getColumnStats();
+ long recordCount = dataFile.getRecordCount();
+ List<ColumnStat> columnStats;
+
+ // For Parquet files, ALWAYS read from footer to match native Iceberg
behavior
Review Comment:
I'm not sure I understand this question in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
