rahil-c commented on code in PR #729:
URL: https://github.com/apache/incubator-xtable/pull/729#discussion_r2566548729
##########
pom.xml:
##########
@@ -615,6 +616,20 @@
<artifactId>jettison</artifactId>
<version>1.5.4</version>
</dependency>
+ <dependency>
+ <groupId>io.delta</groupId>
+ <artifactId>delta-kernel-api</artifactId>
+ <version>${delta.kernel.version}</version>
+ <scope>provided</scope>
Review Comment:
@vaibhavk1992 @the-other-tim-brown When i tried reproducing by setting this
to `compile` I hit the following errors, in xtable service. I am not sure why
this breaks from having delta kernel as compile scope.
```
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR]
/Users/rahil/workplace/incubator-xtable/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java:[35,30]
package org.apache.hadoop.conf does not exist
[ERROR]
/Users/rahil/workplace/incubator-xtable/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java:[75,17]
cannot find symbol
symbol: class Configuration
location: class org.apache.xtable.service.ConversionService
[ERROR]
/Users/rahil/workplace/incubator-xtable/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java:[105,11]
cannot find symbol
symbol: class Configuration
location: class org.apache.xtable.service.ConversionService
[ERROR]
/Users/rahil/workplace/incubator-xtable/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java:[140,72]
cannot find symbol
symbol: class Configuration
location: class org.apache.xtable.service.ConversionService
[ERROR]
/Users/rahil/workplace/incubator-xtable/xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java:[175,7]
cannot find symbol
symbol: class Configuration
location: class org.apache.xtable.service.ConversionService
```
This class seems to come from `hadoop-common`
<img width="313" height="233" alt="Screenshot 2025-11-26 at 1 35 32 PM"
src="https://github.com/user-attachments/assets/fb780784-cf28-42b9-b924-10aa87d63469";
/>
In order to get past the build exception I included in the `xtable-service`
pom and was able to get build to pass.
```
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
</dependency>
```
I am ok with the exclusion idea that @the-other-tim-brown mentioned if it
allows the build to pass. but wanted to know if this was more ideal instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
