xr-chen commented on code in PR #766:
URL: https://github.com/apache/incubator-xtable/pull/766#discussion_r2607676605
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergSchemaExtractor.java:
##########
@@ -1044,4 +1044,55 @@ public void testToIcebergWithNoFieldIdsSet() {
Assertions.assertTrue(
icebergRepresentation.sameSchema(SCHEMA_EXTRACTOR.toIceberg(internalSchema)));
}
+
+ @Test
+ public void testToIcebergWithPartialFieldIdsSet() {
+ InternalSchema internalSchema =
+ InternalSchema.builder()
+ .name("testRecord")
+ .dataType(InternalType.RECORD)
+ .isNullable(false)
+ .fields(
Review Comment:
Does this field to be added come with an ID or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
