kevinjqliu commented on code in PR #784:
URL: https://github.com/apache/incubator-xtable/pull/784#discussion_r2706241047
##########
xtable-core/src/test/java/org/apache/xtable/iceberg/TestIcebergSync.java:
##########
@@ -106,6 +108,7 @@
* Validates that the metadata for the table is properly created/updated.
{@link
* ITConversionController} validates that the table and its data can be
properly read.
*/
+@Execution(ExecutionMode.SAME_THREAD)
Review Comment:
this is so that github CI wont run into concurrency issues, i see this is
done for `TestDeltaSync` as well
##########
xtable-core/src/test/resources/schemas/basic_schema.avsc:
##########
@@ -72,20 +72,23 @@
},
{
"name": "bytes_field",
- "type": "bytes",
- "default": ""
+ "type": ["null", "bytes"],
+ "default": null
Review Comment:
i believe this is needed for the new parquet library version, but let me
revert and see
##########
pom.xml:
##########
@@ -748,6 +787,22 @@
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<trimStackTrace>false</trimStackTrace>
<forkedProcessExitTimeoutInSeconds>120</forkedProcessExitTimeoutInSeconds>
+ <argLine>
+ --add-opens=java.base/java.lang=ALL-UNNAMED
Review Comment:
i was using java 17 due to the quarkus issue, removed from this pr
##########
xtable-core/src/test/resources/schemas/basic_schema.avsc:
##########
@@ -72,20 +72,23 @@
},
{
"name": "bytes_field",
- "type": "bytes",
- "default": ""
+ "type": ["null", "bytes"],
+ "default": null
Review Comment:
yep, fails with
```
Caused by: org.apache.avro.AvroTypeException: Invalid default for field
bytes_field: "" not a "bytes"
at org.apache.avro.Schema.validateDefault(Schema.java:1719)
at org.apache.avro.Schema$Field.<init>(Schema.java:578)
at org.apache.avro.Schema$Field.<init>(Schema.java:614)
at
org.apache.hudi.avro.HoodieAvroUtils.addMetadataFields(HoodieAvroUtils.java:291)
at
org.apache.hudi.io.HoodieWriteHandle.<init>(HoodieWriteHandle.java:96)
at
org.apache.hudi.io.HoodieCreateHandle.<init>(HoodieCreateHandle.java:89)
at
org.apache.hudi.io.HoodieCreateHandle.<init>(HoodieCreateHandle.java:76)
at
org.apache.hudi.io.CreateHandleFactory.create(CreateHandleFactory.java:45)
at
org.apache.hudi.execution.CopyOnWriteInsertHandler.consume(CopyOnWriteInsertHandler.java:85)
at
org.apache.hudi.execution.CopyOnWriteInsertHandler.consume(CopyOnWriteInsertHandler.java:42)
at
org.apache.hudi.common.util.queue.SimpleExecutor.execute(SimpleExecutor.java:69)
... 26 more
```
https://github.com/apache/incubator-xtable/actions/runs/21153333020/job/60833552403?pr=784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
