the-other-tim-brown commented on code in PR #806:
URL: https://github.com/apache/incubator-xtable/pull/806#discussion_r2838510757
##########
xtable-core/src/test/java/org/apache/xtable/parquet/ITParquetConversionSource.java:
##########
@@ -165,12 +164,21 @@ private static ConversionConfig getTableSyncConfig(
.build();
}
- private static Stream<Arguments> provideArgsForFileNonPartitionTesting() {
- String partitionConfig = null;
- return Stream.of(
- Arguments.of(
- buildArgsForPartition(
- PARQUET, Arrays.asList(ICEBERG, DELTA, HUDI), partitionConfig,
partitionConfig)));
+ private static Stream<Arguments> provideArgsForSyncTesting() {
+ List<String> partitionConfigs = Arrays.asList(null,
"timestamp:MONTH:year=yyyy/month=MM");
+ return partitionConfigs.stream()
+ .flatMap(
+ partitionConfig ->
+ Stream.of(SyncMode.FULL) // Incremental sync is not yet
supported
Review Comment:
Provides setup for the incremental sync mode so the tests can be quickly
updated in the future to cover those cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
