vinishjail97 commented on code in PR #805:
URL: https://github.com/apache/incubator-xtable/pull/805#discussion_r2841926472
##########
xtable-core/src/main/java/org/apache/xtable/parquet/ParquetStatsExtractor.java:
##########
@@ -65,92 +65,76 @@ public static ParquetStatsExtractor getInstance() {
private static PathBasedPartitionSpecExtractor partitionSpecExtractor =
ParquetPartitionSpecExtractor.getInstance();
- public static List<ColumnStat> getColumnStatsForaFile(ParquetMetadata
footer) {
- return getStatsForFile(footer).values().stream()
- .flatMap(List::stream)
- .collect(Collectors.toList());
- }
+ @SuppressWarnings("unchecked")
Review Comment:
Follow-up from previous comment #1: `getMaxFromColumnStats` and
`toInternalDataFile` were removed (good), but three static fields are still
unused after the refactor:
- `schemaExtractor` (line 61) — replaced by `SchemaFieldFinder` in
`mergeColumnChunks`
- `partitionValueExtractor` (line 63)
- `partitionSpecExtractor` (line 65)
The `PathBasedPartitionSpecExtractor` import is also dead. Clean these up to
avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
