vinishjail97 commented on PR #818:
URL: https://github.com/apache/incubator-xtable/pull/818#issuecomment-4202525932

   Addressed all feedback in cf186db:
   - Renamed `classifyFileByMetadataStats` to `tryEnrichWithMetadataStats` and 
changed it to return `Optional<InternalDataFile>` — present means stats found, 
empty means needs fallback. The caller uses `ifPresentOrElse` to route into the 
two lists. (comment 1)
   - Added an early return of `Optional.empty()` when `fileStats` is empty, 
avoiding the unnecessary `toBuilder()` and object creation. (comment 2)
   - Renamed `fallen` to `fromFooter` to match `fromMeta`. (comment 3)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to