vinishjail97 commented on PR #816:
URL: https://github.com/apache/incubator-xtable/pull/816#issuecomment-4202525698

   Addressed all feedback in 884cb0f:
   - Added `HoodieTableType tableType` param to `insertOverwrite` and passed it 
to `CommitUtils.getCommitActionType` instead of hardcoding `COPY_ON_WRITE` 
(comment 1)
   - Changed return type to `void` and removed the redundant `return records;` 
(comment 2)
   - Converted `testMultipleInsertOverwriteOnSamePartitions` to 
`@ParameterizedTest` / `@MethodSource("testsForAllTableTypes")` following the 
same pattern as `testsForDropPartition` — now covers both COW and MOR (comment 
3)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to