vinishjail97 commented on PR #178:
URL: https://github.com/apache/incubator-xtable/pull/178#issuecomment-4202706321

   Thank you for the contribution, @vamshigv.
   
   After reviewing this PR and the discussion, we're closing it for the 
following reasons:
   
   1. **Architectural concerns were not resolved.** As @ashvina noted, changing 
the `SourceClient` generic contract from `Snapshot` to `Long` purely for 
serialization efficiency is a leaky abstraction — it would implicitly require 
all future source format implementations to expose a `Long` commit identifier, 
which may not be a natural fit for every format. The consensus was that a 
proper `OneCommit` abstraction (tracking issue 
[#135](https://github.com/onetable-io/onetable/issues/135)) is the right path 
forward rather than pushing format-specific constraints into the shared 
interface.
   
   2. **The codebase has since diverged.** The project has been renamed and 
restructured under the Apache incubation process (`org.apache.xtable`), and 
`SourceClient` has been superseded by `ConversionSource`. The current 
`IcebergConversionSource` retains `Snapshot` as the type parameter, reflecting 
the direction the community chose. This PR would need a full rewrite to apply 
cleanly.
   
   If there is renewed interest in reducing serialization overhead for the 
Iceberg commit representation, we welcome a new proposal tied to the current 
codebase and discussed on the dev mailing list ([email protected]) before 
implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to