vinishjail97 commented on PR #782: URL: https://github.com/apache/incubator-xtable/pull/782#issuecomment-4203025358
Closing this draft PR. The approach here — calling `deltaLog.getChanges()` to probe for vacuumed commit files — is reasonable in intent but has a meaningful downside: it eagerly opens and partially iterates the commit log on every incremental sync safety check, adding unnecessary I/O overhead on the hot path. As @brishi19791 noted, there may be a simpler fix via the `mustBeRecreatable` flag on `getActiveCommitAtTime`. Additionally, the PR body was never filled out and the implementation was left as a draft without tests. Given it has been idle for ~3 months with the approach still in question, closing for now. If the VACUUM-induced log truncation issue resurfaces, the fix should come with a clear description of the failure scenario, a unit/integration test that reproduces it, and a more targeted approach (e.g., verifying the `mustBeRecreatable` flag behavior or checking log file existence directly without iterating changes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
