brishi19791 opened a new pull request, #826:
URL: https://github.com/apache/incubator-xtable/pull/826

   [#852](https://github.com/apache/incubator-xtable/issues/825)
   Both DeltaSchemaExtractor and DeltaKernelSchemaExtractor were passing 
MAP_VALUE_FIELD_NAME when recursing into a map key, so nested fields under a 
complex (struct/array/map) map key were qualified with 
"<map>._one_field_value.<child>" instead of"<map>._one_field_key.<child>". This 
collides with the value-side fully-qualified paths and breaks any downstream 
lookup keyed off InternalField.parentPath (column stats, field resolution, 
etc.).
   
   Changes:
   - DeltaSchemaExtractor: pass MAP_KEY_FIELD_NAME when building the key
     schema's parent path.
   - DeltaKernelSchemaExtractor: same fix; additionally promote
     trimmedTypeName/type from singleton instance fields to method-local
     variables (the new test exposed cross-test state corruption via the
     shared mutable fields) and throw NotSupportedException on unknown
     DataType to keep the locals definitely-assigned.
   - TestDeltaSchemaExtractor / TestDeltaKernelSchemaExtractor: add
     testMapWithStructKey covering a map whose key is a 2-field struct
     (nullable + non-nullable) and whose value is also a struct, asserting
     both _one_field_key and _one_field_value nested parentPath
     propagation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to