vinishjail97 commented on PR #768:
URL: https://github.com/apache/incubator-xtable/pull/768#issuecomment-4634632043

   Pushed 2170d361 to address two of the review items (verified locally: 
`TestParquetDataManager` 10/10, `ITParquetConversionSource` 6/6):
   
   1. **Fetch the parquet listing once** — this was originally 
@the-other-tim-brown's [Jan-19 
comment](https://github.com/apache/incubator-xtable/pull/768#discussion_r2705819343);
 it stayed open after the later rewrites. `getTableChangeForCommit` and 
`getCurrentSnapshot` now list the filesystem once per operation and stream from 
the materialized list.
   
   2. **Removed dead `ParquetDataManager` methods** — `getParquetDataFileAt` 
and `getParquetFilesMetadataAfterTime` had no production caller (they were 
wired into an earlier revision of `getTableChangeForCommit` but dropped in the 
rewrite). Removed them and their tests; repointed the real-FS tests to 
`getCurrentFilesInfo`.
   
   Deliberately **not** included here: the `sourceIdentifier` snapshot-skew 
point (commit identifier derived from a separate 
`parquetDataManager.getMostRecentParquetFile()` listing than the one used for 
the table/changes). That's a net-new correctness question, so leaving it for 
discussion rather than folding it into this cleanup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to