rangareddy commented on code in PR #848:
URL: https://github.com/apache/incubator-xtable/pull/848#discussion_r3642810143
##########
.asf.yaml:
##########
@@ -35,6 +35,19 @@ github:
main:
required_pull_request_reviews:
required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ branch-0.4:
+ required_pull_request_reviews:
+ required_approving_review_count: 1
+ required_status_checks:
+ contexts:
+ - "Maven CI Build"
+ - "License Check"
+ - "validate-spark-runtime-bundle (3.4.3)"
+ - "validate-spark-runtime-bundle (3.5.9)"
Review Comment:
No — GitHub required status checks are exact-string matches (no
wildcards/globs), and `.asf.yaml` passes `contexts` straight through to GitHub
branch protection, so a matrix job forces us to enumerate each version.
The standard workaround is a single aggregate "gate" job that `needs:` the
matrix and passes only if every leg succeeds, then require that one stable
context. I've opened #862 against `branch-0.4` adding a
`spark-runtime-validation-required` job to `spark-runtime-validation.yml` (uses
`if: always()` so it still reports rather than being skipped when a leg fails).
Once #862 lands, drop the two versioned lines here and require just the one
gate context, so the `branch-0.4` block reads:
```yaml
required_status_checks:
contexts:
- "Maven CI Build"
- "License Check"
- "spark-runtime-validation-required"
```
That way `.asf.yaml` never needs editing when the Spark matrix changes.
Merge order: #862 to `branch-0.4` first, then apply this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
