rangareddy opened a new pull request, #866:
URL: https://github.com/apache/incubator-xtable/pull/866

   ## What
   
   Removes orphaned `META-INF/licenses/LICENSE-*` files from the bundled 
(shaded) jars — license texts for libraries that are **not** actually bundled 
(no classes present), because their artifacts are not in the shade 
`<artifactSet><includes>`.
   
   Closes #865
   
   ## Removed files (verified against each module's shade includes)
   
   | Module | Removed | Why |
   |---|---|---|
   | `xtable-aws` | `LICENSE-antlr4-runtime`, 
`LICENSE-glassfish-java-servlet-jsp`, `LICENSE-slf4j-api` | none of these 
artifacts are in the aws shade includes |
   | `xtable-hudi-support-extensions` | `LICENSE-antlr4-runtime`, 
`LICENSE-javax-annotation-api` | not in that module's shade includes |
   | `xtable-hive-metastore` | `LICENSE-slf4j-api` | `org.slf4j:slf4j-api` is 
not shaded here |
   
   Kept where the library *is* bundled — e.g. `LICENSE-javax-annotation-api` in 
`xtable-aws` (`javax.annotation:javax.annotation-api` is in its includes) and 
`LICENSE-slf4j-api` in `xtable-hudi-support-extensions` (`org.slf4j:slf4j-api` 
is in its includes).
   
   ## Verification
   
   For each removed file I confirmed the corresponding artifact is absent from 
the module's `maven-shade-plugin` `<artifactSet><includes>`, so its classes are 
not in the jar and the license text is orphaned.
   
   ## Note
   
   The larger PR #857 (bundle license texts for non-Apache-2.0 dependencies) 
regenerates the entire `META-INF/licenses/` directory and would also remove 
these orphans as a side effect; this PR is the minimal, targeted fix for #865 
and can merge independently.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to