vinishjail97 commented on code in PR #867:
URL: https://github.com/apache/incubator-xtable/pull/867#discussion_r3660446968


##########
xtable-service/pom.xml:
##########
@@ -250,6 +250,15 @@
     </dependencies>
     <build>
         <plugins>
+            <!--

Review Comment:
   Shorten this comment and link this page? 
   https://quarkus.io/guides/maven-tooling#bootstrap-maven-properties 



##########
.github/workflows/mvn-ci-build.yml:
##########
@@ -45,3 +45,28 @@ jobs:
 
       - name: Build all module with Maven
         run: ./mvnw clean install -ntp -B
+
+  package:

Review Comment:
   Do we really need this change here? Wouldn't it affect all the builds? Can 
we validate this as part of xtable-service CI only? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to