slachiewicz commented on issue #736: URL: https://github.com/apache/incubator-xtable/issues/736#issuecomment-5368127346
@the-other-tim-brown asked above whether `jol-core` was removed for licence reasons, and I don't think it was ever answered. Coming back to it now because #840 put it into the shaded jar. `org.openjdk.jol:jol-core:0.16` is GPL-2.0 with the Classpath Exception (declared in `jol-parent`). That is **Category B**, not Category X, so it is allowed — but the [policy](https://www.apache.org/legal/resolved.html) sets two conditions for binary distribution: > Confirm the dependency is fully under the ClasspathException-2.0 and that it does not contain GPL-2.0 **without** the ClasspathException-2.0 > > Confirm that the dependency is a separate module from the other works in the product (typically a separate jar file) The second one is the problem. `jol-core` is in the `<artifactSet><includes>` of `xtable-utilities`, so its 86 classes are shaded into `xtable-utilities_2.12-*-bundled.jar` rather than shipped as a separate jar. I don't think this blocks anything today, and I'm not asserting it is a violation — reading "separate module" against a shaded uber-jar is exactly the kind of call the PMC should make rather than me. But it should be a deliberate answer rather than a side effect of fixing the `NoClassDefFoundError`. Options if it turns out to matter: keep `jol-core` outside the shade and document it as a runtime dependency, or check whether current Hudi still needs `ObjectSizeCalculator` on this path. Found while auditing the bundled licence metadata for #701. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
