vinishjail97 commented on code in PR #898:
URL: https://github.com/apache/incubator-xtable/pull/898#discussion_r3834205916
##########
pom.xml:
##########
@@ -702,6 +706,38 @@
</resourceBundles>
</configuration>
</execution>
+ <!--
+ Renders the bundled jar's LICENSE for the shaded modules.
+ Must run before process-resource-bundles, or that
execution
+ copies its own META-INF/LICENSE verbatim and the render
is
+ skipped.
+ -->
+ <execution>
+ <id>process-bundled-resources</id>
Review Comment:
Hi @slachiewicz, any idea which ASF projects generate the bundled LICENSE
this way? Naming them would help weigh this against #895.
HBase looks like the closest precedent: `hbase-resource-bundle` renders
`META-INF/LICENSE.vm` and `NOTICE.vm` through `maven-remote-resources-plugin`
with `supplemental-models.xml`, and `hbase-shaded` pairs that with
`ApacheNoticeResourceTransformer` the same way this does.
I have looked at Apache Spark, Apache Hudi, Apache Iceberg and Apache Kafka
all of them seem to have hand-maintained and validation scripts like XTable.
Please correct me if I'm wrong.
https://github.com/apache/iceberg/blob/main/dev/check-license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
